feat: add 'lowercase-title' option to upgrade action #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TylerJang27 Could you take a look at this? |
det
approved these changes
Jan 29, 2024
Hi, thanks for taking a look. Sure thing, I have now fixed the stylelint issue. To test the change I have a title_message="Upgrade trunk"
if [[ ${LOWERCASE_TITLE} == "true" ]]; then
title_message=$(echo "${title_message}" | tr '[:upper:]' '[:lower:]')
fi
echo "${title_message}"and executed it with different options: |
Adds 'lowercase-title' option to the 'trunk-action/upgrade' action.
Specifying the option converts the PR / commit title "Upgrade trunk"
to lowercase, i.e. "upgrade trunk"
Example usage:
- uses: trunk-io/trunk-action/upgrade@v1
with:
prefix: "chore(deps): "
lowercase-title: true
This change makes it possible to use the trunk upgrade action in a way
that conforms to the commitlint '@commitlint/config-conventional'
configuration which specifies that commit message subject must not be
sentence-case, start-case, pascal-case, upper-case. With the default
commit message title "Upgrade trunk" and `prefix: "chore(deps): "` the
following error is emitted by commitlint using `config-conventional`:
⧗ input: chore(deps): Upgrade trunk to 1.19.0
✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
rriski
added a commit
to aiven/aiven-operator
that referenced
this pull request
Jan 30, 2024
Implemented upstream in trunk-io/trunk-action#218
rriski
added a commit
to aiven/aiven-operator
that referenced
this pull request
Jan 30, 2024
These options are added to get the automated commit to pass commitlint. Implemented upstream in trunk-io/trunk-action#218
|
Thank you @TylerJang27 for your review and for merging this into main. Could we possibly arrange for a new release to be issued? This would allow us to utilize the new option. |
|
Yep, we'll get this released shortly! @puzzler7 |
|
@rriski It's released and the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 'lowercase-title' option to the 'trunk-action/upgrade' action. Specifying the option converts the PR / commit title "Upgrade trunk" to lowercase, i.e. "upgrade trunk"
Example usage:
This change makes it possible to use the trunk upgrade action in a way that conforms to the commitlint '@commitlint/config-conventional' configuration which specifies that commit message subject must not be sentence-case, start-case, pascal-case, upper-case. With the default commit message title "Upgrade trunk" and
prefix: "chore(deps): "the following error is emitted by commitlint usingconfig-conventional:⧗ input: chore(deps): Upgrade trunk to 1.19.0
✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint