Counter should be 8 bytes long #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With 4 bytes the test vectors do not pass the right values.
Similarly, the TOTP implementatation uses 8 byte long int.
As per RFC4226, 5.1. Notation and Symbols [1]:
C 8-byte counter value, the moving factor. This counter
MUST be synchronized between the HOTP generator (client)
and the HOTP validator (server).
[1] https://www.rfc-editor.org/rfc/rfc4226#page-5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With counter size equal to 4 bytes the test vectors do not pass back the right values for HOTP. Similarly, the TOTP implementation uses 8 byte long int, hence it seems that this is a typo. At the same time the YK's protocol does accept only 4-byte counters.
As per RFC4226, 5.1. Notation and Symbols [1]:
[1] https://www.rfc-editor.org/rfc/rfc4226#page-5