Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Upload page redesign #182

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

carlosthe19916
Copy link
Member

@carlosthe19916 carlosthe19916 commented Oct 4, 2024

Fixes #181, #161

UI Tests PR: 4

  • The v1 upload pages are just awful IMHO. They allow you to only upload one file at a time. Moreover, it previews the content of the file being uploaded which some times blows the browser's memory as SBOMs and Advisory files can be huge some times.

Here is a proposal for the UX team + PM to move the Upload button to the Top Nav Bar of the Page (just like Openshift does). This will allow to have visibility over the "Upload button" all the time.

This idea was inspired by an internal chat with @chirino

This is how it would look like

Screencast.from.2024-10-04.16-25-40.mp4

The current implementation has 2 tabs one for SBOMs and another Advisories.

TODO

  • If this is approved by UX then it will make sense to request the backend to just have a single REST endpoint where we can upload files so it does not matter whether or not they are an SBOM of Advisory. Users will be able to just drop their files all in a single batch
  • Currently the upload endpoint does not support multipart/form which is the way of getting a numeric progress of the upload. The current endpoint does not allow to track the progress of the upload . Unless there is a way to do it without multipart/form we will need it to be implemented in the backend.

@chirino
Copy link
Contributor

chirino commented Oct 4, 2024

Looks great! That (+) is ok, but someone might think it means add.
I feel that there should be a better icon for denoting uploads.

@carlosthe19916 carlosthe19916 requested review from gildub and removed request for gildub October 8, 2024 07:13
@carlosthe19916
Copy link
Member Author

  • @mid998 Suggested to move the "Upload" button from the top navbar to the left sidebar. I applied that change
  • Allowed to support uploading .bz2 files (compressed files)
  • Change the Dockerfile.server file to fix a wrong line that was not allowing the creation of the container appropriately

As part of this PR I created its e2e tests here trustification/trustify-ui-tests#4 and this PR is using trustification/trustify-ui-tests#4 to actually validate this PR (the Upload page).

If in this repository we want to run the e2e tests against a PR in the trustify-ui-test repo we only need to write a comment in the description of the PR e.g.

UI Tests PR: 4

The line above means to test this PR against the PR number 4 of the trustify-ui-tests repo. Which in this case means trustification/trustify-ui-tests#4

@carlosthe19916 carlosthe19916 marked this pull request as ready for review October 8, 2024 11:20
@carlosthe19916 carlosthe19916 self-assigned this Oct 8, 2024
@carlosthe19916 carlosthe19916 merged commit a50950c into trustification:main Oct 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Upload V1 compatibility
3 participants