Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update client/openapi/trustd.yaml #218

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

carlosthe19916
Copy link
Member

Update trustify openapi definition

@carlosthe19916
Copy link
Member Author

@kahboom this is an automated PR generated by the backend after the openapi.yaml file changes.
We use the openapi.yaml file to generate the REST client in this repository.

I think you requested the "reserved" field to be added to vulnerabilities therefore the openapi definition has changed. However, there is an error in one of the stories.

If you need to get the "reserved" field in the UI you can merge this PR but we will need to fix the ci build errors first

@kahboom
Copy link
Contributor

kahboom commented Nov 5, 2024

@carlosthe19916 noted. I'm on the fence about whether we should give a warning rather than fail the build if there's an issue with Storybook.

@carlosthe19916
Copy link
Member Author

IMO although painful it is good to have errors also in storybook. If we do not have errors we won't be able to fix them as those errors might be overlooked.

I would say better to be safe even if it takes us more time to maintain the code

@trust-git-bot
Copy link

🚀 Storybook Deployed Preview: https://trustify-ui-pr-218-preview.surge.sh

@kahboom kahboom merged commit 4fb437a into main Nov 6, 2024
8 checks passed
@kahboom kahboom deleted the create-pull-request/patch-87cb954 branch November 6, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants