Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add TLS ConfigMap parameter #269

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ruivieira
Copy link
Member

@ruivieira ruivieira commented Aug 2, 2024

This PR adds a new field to the TrustyAI operator configuration ConfigMap called tls with can be either enabled or disabled.

  • If tls: enabled, payload processors will be registered with ModelMesh as https. This is the default value if the configuration key is missing.
  • If tls: disabled, payload processors will be registered as http. This is the opt-in value, only set if explicitly changed on the config map.

Two overlays were also updated:

key odh rhoai
tls disabled enabled
kServeServerless enabled disabled
OAuth container image tag 4.14 sha registry.redhat.io/openshift4/ose-oauth-proxy@sha256:ab112105ac37352a2a4916a39d6736f5db6ab4c29bad4467de8d613e80e9bb33

This allows for:

  • odh: TLS-disabled and KServe integration enabled
  • rhoai: TLS-enabled and KServe integration disabled and a pinned OAuth proxy image

Update ODH and RHOAI overlays
Copy link

github-actions bot commented Aug 2, 2024

PR image build and manifest generation completed successfully!

📦 PR image: quay.io/trustyai/trustyai-service-operator-ci:e0e0c7f1b8b191841ba6e4a07427bded5dd57ef4

🗂️ CI manifests

Copy link

openshift-ci bot commented Aug 2, 2024

@ruivieira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/trustyai-service-operator-e2e e0e0c7f link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RobGeada

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants