-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Add new API endpoint for enhancing prompts at /api/v1/prompts/canvas #112
Conversation
WalkthroughThe changes introduce a new API endpoint at Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/libs/LangSmith/openapi.yaml (1)
15170-15194
: Consider adding validation constraints to the schema.The PlaygroundOptimizePromptRequestSchema could benefit from additional validation:
- Add length constraints for the prompt and improvement_instruction fields to prevent extremely large inputs
- Add pattern validation for template_format to ensure consistent casing
- Add range validation for highlight_start and highlight_end to ensure they are non-negative and highlight_end > highlight_start
Apply these changes to improve input validation:
PlaygroundOptimizePromptRequestSchema: title: PlaygroundOptimizePromptRequestSchema required: - prompt - improvement_instruction - template_format type: object properties: prompt: title: Prompt type: string + maxLength: 32768 + minLength: 1 highlight_start: title: Highlight Start type: integer + minimum: 0 nullable: true highlight_end: title: Highlight End type: integer + minimum: 0 nullable: true improvement_instruction: title: Improvement Instruction type: string + maxLength: 1024 + minLength: 1 template_format: title: Template Format enum: - f-string - mustache type: string + pattern: "^[a-z-]+$"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (15)
src/libs/LangSmith/Generated/JsonConverters.PlaygroundOptimizePromptRequestSchemaTemplateFormat.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/JsonConverters.PlaygroundOptimizePromptRequestSchemaTemplateFormatNullable.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/JsonSerializerContext.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/JsonSerializerContextTypes.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.FeedbackClient.CreateFeedback.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.FeedbackClient.EagerlyCreateFeedback.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.IFeedbackClient.CreateFeedback.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.IFeedbackClient.EagerlyCreateFeedback.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.IPromptsClient.Canvas.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.Models.CanvasApiV1PromptsCanvasPostResponse.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.Models.FeedbackCreateSchema.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.Models.OrganizationConfig.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.Models.PlaygroundOptimizePromptRequestSchema.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.Models.PlaygroundOptimizePromptRequestSchemaTemplateFormat.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.PromptsClient.Canvas.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
- src/libs/LangSmith/openapi.yaml (4 hunks)
🔇 Additional comments (1)
src/libs/LangSmith/openapi.yaml (1)
7380-7408
: LGTM! The new canvas endpoint is well-defined.The endpoint is properly secured and follows RESTful conventions with appropriate request/response schemas.
Summary by CodeRabbit
New Features
/api/v1/prompts/canvas
for prompt improvement based on user instructions.Documentation