fix: edge case of portal user existing before employee record

apps/app/src/actions/people/create-employee-action.ts

@@ -1,6 +1,6 @@
 "use server";
 
-import { db } from "@bubba/db";
+import { type Employee, db } from "@bubba/db";
 import { PrismaClientKnownRequestError } from "@prisma/client/runtime/library";
 import { authActionClient } from "../safe-action";
 import { createEmployeeSchema } from "../schema";
@@ -46,20 +46,56 @@ export const createEmployeeAction = authActionClient
     }
 
     try {
-      // Create the employee
-      const employee = await db.employee.create({
-        data: {
-          name,
-          email,
-          department,
-          organizationId: user.organizationId,
-          isActive: true,
-          externalEmployeeId,
+      // First check if an employee exists (active or inactive)
+      const existingEmployee = await db.employee.findUnique({
+        where: {
+          email_organizationId: {
+            email,
+            organizationId: user.organizationId,
+          },
         },
       });
 
-      const portalUser = await db.portalUser.create({
-        data: {
+      let employee: Employee;
+
+      if (existingEmployee) {
+        if (existingEmployee.isActive) {
+          return {
+            success: false,
+            error:
+              "An employee with this email already exists in your organization",
+          };
+        }
+
+        // Reactivate the existing employee
+        employee = await db.employee.update({
+          where: { id: existingEmployee.id },
+          data: {
+            name,
+            department,
+            isActive: true,
+            externalEmployeeId,
+            organizationId: user.organizationId,
+            updatedAt: new Date(),
+          },
+        });
+      } else {
+        employee = await db.employee.create({
+          data: {
+            name,
+            email,
+            department,
+            organizationId: user.organizationId,
+            isActive: true,
+            externalEmployeeId,
+          },
+        });
+      }
+
+      // Update or create portalUser
+      const portalUser = await db.portalUser.upsert({
+        where: { email },
+        create: {
           id: employee.id,
           name,
           email,
@@ -73,6 +109,17 @@ export const createEmployeeAction = authActionClient
             },
           },
         },
+        update: {
+          updatedAt: new Date(),
+          name,
+          email,
+          organizationId: user.organizationId,
+          employees: {
+            connect: {
+              id: employee.id,
+            },
+          },
+        },
       });
 
       // Create or get the required task definitions first and store their IDs
@@ -87,7 +134,7 @@ export const createEmployeeAction = authActionClient
             },
             update: {},
           });
-        })
+        }),
       );
 
       // Now create the employee tasks using the actual task IDs
@@ -100,7 +147,7 @@ export const createEmployeeAction = authActionClient
               status: "assigned",
             },
           });
-        })
+        }),
       );
 
       return {