-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report branchconditions / FailureContext #1
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, modulo minor cosmetic code changes. If time permits, I'll bring this PR up in the next Viper meeting, so see if anybody objects against the changes.
var failureContexts: Seq[FailureContext] = Seq() //TODO: make immutable | ||
|
||
} | ||
trait FailureContext { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline between trait declarations
rm | ||
} | ||
} | ||
override def readableMessage : String = (readableMessage(false, true) + failureContexts.map(e => e.toString).mkString("\n")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Not your "fault", but please change to
readableMessage: String
(whitespace) - Drop the parentheses surrounding the right-hand side expression
PR to get feedback from @mschwerhoff