Add baseUrl notices to readme
#247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperupcall
force-pushed
the
hyperupcall-baseurl
branch
from
410a106 to
de3f9db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the documentation to add a notice that
baseUrlmay need to be set manually, for places where it is relevant.But, checking the docs for baseUrl, it seems that it is only recommended for use with AMD module loaders (since TypeScript 4.1, it is no longer required when using 'paths`). So, I'm thinking it might be better just to remove the properties all together (with no documentation update)? That will still address the "confusion" from the linked issue, and not add "notices" that do not apply for most people.
Closes #223