Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): fix integer type when Nullable decorator is used #2756

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

Romakita
Copy link
Collaborator

Closes: #2754

Information

Type Breaking change
Fix No

@Romakita Romakita merged commit d5ba9d0 into production Jul 18, 2024
@Romakita Romakita deleted the fix-2754-nullable-integer-schema branch July 18, 2024 12:01
@Romakita
Copy link
Collaborator Author

🎉 This PR is included in version 7.76.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

Benchmarks

  • Machine: linux x64 | 4 vCPUs | 15.6GB Mem
  • Node: v18.20.4
  • Run: Thu Jul 18 2024 12:12:20 GMT+0000 (Coordinated Universal Time)
  • Method: autocannon -c 100 -d 10 -p 10 localhost:3000 (two rounds; one to warm-up, one to measure)
Version Router Requests/s Latency Throughput/Mb
koa 2.13.4 32029.6 30.70 5.71
tsed-koa 7.76.0 11389.6 86.93 9.64
express 4.19.2 10292.0 96.29 1.84
nest 8.4.3 9520.9 103.89 2.29
express-injector 4.19.2 9059.8 109.47 2.06
tsed-express 7.76.0 8293.6 119.46 1.52
express-morgan 4.19.2 5318.3 186.10 0.95
fastify-big-json 3.29.4 N/A N/A N/A
fastify-injector 3.29.4 N/A N/A N/A
fastify 3.29.4 N/A N/A N/A
nest-fastify 8.4.3 N/A N/A N/A

Explanation

The benchmark shows a performance difference between the frameworks. We note that Ts.ED is often last. In fact, Ts.ED uses features useful to a production application which reduce its performance.

For example, Ts.ED initializes a sandbox (async_hook) for each request in order to work in an isolated context if necessary.
It also initializes the elements necessary for monitoring requests in a log manager.

All this at a necessary cost that reflects the reality of a production application ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] @Integer annotation is no more taking into model when used with @Nullable(Number)
1 participant