-
Notifications
You must be signed in to change notification settings - Fork 0
WIP: Boundary orthogonalization based on source terms #31
base: elliptic-grid-gen
Are you sure you want to change the base?
WIP: Boundary orthogonalization based on source terms #31
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
(typeof(Q) <: Nothing ? 0 : γ(u)*Q(xs[u], ys[u])*∂yη(u)) | ||
@inline PfO(u::CartesianIndex) = 0 | ||
@inline QfO(u::CartesianIndex) = 0 | ||
@inline PwO(u::CartesianIndex) = doBO && u[1] in axes(xs)[1][[begin:begin+1, end-1 : end ]] ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to @chromolakyro's recognition, this indexing syntax is problematic. Should be:
@inline PwO(u::CartesianIndex) = doBO && u[1] in axes(xs)[1][[begin:begin+1, end-1 : end ]] ? | |
@inline PwO(u::CartesianIndex) = doBO && u[1] in axes(xs)[1][[begin:begin+1 end-1 : end ]] ? |
this is already implemented by @chromolakyro; he will push later today.
No description provided.