Improve no-edge-metadata error #3063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromekelleher
approved these changes
Nov 22, 2024
c/tskit/core.c
Outdated
| @@ -277,7 +277,10 @@ tsk_strerror_internal(int err) | |||
| break; | |||
| case TSK_ERR_CANT_PROCESS_EDGES_WITH_METADATA: | |||
| ret = "Can't squash, flush, simplify or link ancestors with edges that have " | |||
| "non-empty metadata. (TSK_ERR_CANT_PROCESS_EDGES_WITH_METADATA)"; | |||
| "non-empty metadata. Removing the metadata from the edges will allow " | |||
| "simplification to proceed. For example using " | |||
There was a problem hiding this comment.
"simplification and other operations"?
There was a problem hiding this comment.
I went with "these operations".
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3063 +/- ##
=======================================
Coverage 89.86% 89.86%
=======================================
Files 29 29
Lines 32150 32150
Branches 5768 5768
=======================================
Hits 28890 28890
Misses 1859 1859
Partials 1401 1401
Flags with carried forward coverage won't be shown. Click here to find out more.
|
benjeffery
force-pushed
the
better-error
branch
from
91c5803 to
7f08dc6
Compare
benjeffery
force-pushed
the
better-error
branch
from
7f08dc6 to
ecc6d33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent issues like #3057