Fix bug with scripted number range filters (elastic#99554) (elastic#9…

…9816)

Co-authored-by: Lukas Olson <[email protected]>

src/plugins/data/common/es_query/filters/range_filter.test.ts

@@ -64,6 +64,29 @@ describe('Range filter builder', () => {
     });
   });
 
+  it('should convert strings to numbers if the field is scripted and type number', () => {
+    const field = getField('script number');
+
+    expect(buildRangeFilter(field, { gte: '1', lte: '3' }, indexPattern)).toEqual({
+      meta: {
+        field: 'script number',
+        index: 'id',
+        params: {},
+      },
+      script: {
+        script: {
+          lang: 'expression',
+          source: '(' + field!.script + ')>=gte && (' + field!.script + ')<=lte',
+          params: {
+            value: '>=1 <=3',
+            gte: 1,
+            lte: 3,
+          },
+        },
+      },
+    });
+  });
+
   it('should wrap painless scripts in comparator lambdas', () => {
     const field = getField('script date');
     const expected =

src/plugins/data/common/es_query/filters/range_filter.ts

@@ -138,7 +138,10 @@ export const buildRangeFilter = (
 };
 
 export const getRangeScript = (field: IFieldType, params: RangeFilterParams) => {
-  const knownParams = pickBy(params, (val, key: any) => key in operators);
+  const knownParams = mapValues(
+    pickBy(params, (val, key: any) => key in operators),
+    (value) => (field.type === 'number' && typeof value === 'string' ? parseFloat(value) : value)
+  );
   let script = map(
     knownParams,
     (val: any, key: string) => '(' + field.script + ')' + get(operators, key) + key