[Transform] Fix aggregation name override for the top_metrics aggs (e…

…lastic#104446) (elastic#104488) * [Transform] Fix aggName for the top_metrics agg * [Transform] update comment Co-authored-by: Dima Arnautov <[email protected]>
tsullivan · Jul 6, 2021 · b85bf3c · b85bf3c
1 parent 4ffffd7
commit b85bf3c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/...sections/create_transform/components/step_define/common/get_default_aggregation_config.ts b/...sections/create_transform/components/step_define/common/get_default_aggregation_config.ts
@@ -43,7 +43,11 @@ export function getDefaultAggregationConfig(
     case PIVOT_SUPPORTED_AGGS.FILTER:
       return getFilterAggConfig(commonConfig);
     case PIVOT_SUPPORTED_AGGS.TOP_METRICS:
-      return getTopMetricsAggConfig(commonConfig);
+      return getTopMetricsAggConfig({
+        ...commonConfig,
+        // top_metrics agg has different naming convention by default
+        aggName: PIVOT_SUPPORTED_AGGS.TOP_METRICS,
+      });
     default:
       return commonConfig;
   }

diff --git a/...lic/app/sections/create_transform/components/step_define/common/top_metrics_agg/config.ts b/...lic/app/sections/create_transform/components/step_define/common/top_metrics_agg/config.ts
@@ -17,7 +17,6 @@ import {
 import { PivotAggsConfigTopMetrics } from './types';
 import { TopMetricsAggForm } from './components/top_metrics_agg_form';
 import { isPopulatedObject } from '../../../../../../../../common/shared_imports';
-import { PIVOT_SUPPORTED_AGGS } from '../../../../../../../../common/types/pivot_aggs';
 
 /**
  * Gets initial basic configuration of the top_metrics aggregation.
@@ -31,8 +30,6 @@ export function getTopMetricsAggConfig(
     isMultiField: true,
     field: isPivotAggsConfigWithUiSupport(commonConfig) ? commonConfig.field : '',
     AggFormComponent: TopMetricsAggForm,
-    /** Default name */
-    aggName: PIVOT_SUPPORTED_AGGS.TOP_METRICS,
     aggConfig: {},
     getEsAggConfig() {
       // ensure the configuration has been completed