Allow for changing of system tree parent #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it possible to update the parent if the information arrives lates Also fix .clang-format using the one from lo2s
cvonelm
force-pushed
the
allow_change_parent
branch
from
a277dc6 to
882a13e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to change the parent of a system_tree_node after it has already been set.
This is useful for lo2s, as I am in the process of rebuilding the Process insertion method.
Currently, we have to take much care to insert the process into the system tree only when we know its parent process, as we can not change it later.
This makes thinking about when in lo2s we already have the system_tree_node for a process, and when not, tedious.
With this change, we can just emplace a bare bones system tree node whenever we need it, as we can simply fill in missing information (such as the parent) later.