Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually expand glob expression in watch_files #24

Merged
merged 1 commit into from
May 15, 2024

Conversation

maltoe
Copy link
Contributor

@maltoe maltoe commented May 15, 2024

As file_system does not support globs, at least not on Linux/inotify.


Hi again @pepicrft

As you can probably tell by now, I'd really like to use LightningCSS, and I love that your little library fits in so nicely in the esbuild/tailwind/etc toolchain style.

However, I've noticed that the project is still in a very early stage and is, for instance, lacking tests entirely. What are your plans going forward?

As file_system does not support globs, at least not on Linux.
@pepicrft
Copy link
Contributor

However, I've noticed that the project is still in a very early stage and is, for instance, lacking tests entirely. What are your plans going forward?

I'd like to add tests, but we don't have much time for that at the moment. Contributions are welcome though, or alternatively, if you'd like to take it, I can transfer the ownership over to you or your employer.

@pepicrft pepicrft merged commit 9166ace into tuist:main May 15, 2024
2 checks passed
@maltoe maltoe deleted the support-watch-globs branch May 15, 2024 14:04
@maltoe
Copy link
Contributor Author

maltoe commented May 15, 2024

OK, but when you say "we", you're indicating that you've using this in production, right?

I'm mostly looking around right now. Not much of a tailwind fan/user, also my company has tons of classic BEM-style CSS in our projects, so having a CSS bundler/minifier nicely integrated into phoenix is very promising. esbuild also does a good-enough job for us, but there are some desirable additional features in lightningcss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants