fix: propagate build error and check if js files exist #297
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valerioageno
requested changes
Jan 12, 2025
There was a problem hiding this comment.
Thanks for the PR! Changes look perfect!
I'd like to ask you also to introduce two test cases for checking that the scripts exist (checking the vite failure is too complex right now; same for the tuono dev command).
To do it, I'd like to ask you to:
- rename
crates/tuono/tests/cli_tests.rsincrates/tuono/tests/cli_build.rs - Add a test case for testing that the
BUILD_JS_SCRIPTdoes not exist - Add a test case for testing that the
BUILD_TUONO_CONFIGdoes not exist
Let me know if I can support you in any way!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context & Description
This PR aims to fix the command
tuono buildnot propagating errors. It also adds checks for commands executing scripts if said script exists.Closes: #278