offlineshadercompiler: shaderdump no longer implies rebuild #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brakhane
force-pushed
the
shaderdump-no-rebuild
branch
from
45d9056 to
ed9f097
Compare
turanszkij
approved these changes
Jan 24, 2025
|
Should be fine with your solution I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing the zstd vs zlib compression the constant rebuilding took a lot of time, so I thought it might be a good idea to not require a full rebuild when using shaderdump.
A few short tests indicate that it does indeed work correctly, though there might be some weird edge case I didn't consider.
Hopefully, this will allow us in the future to speed up builds of PRs even more, but currently I can't think of a reliable way, as two separate PRs might modify different shaders.
This PR doesn't affect the github builds, as those are using "rebuild" explicitly, and also start with a clean slate every time.