Enable 'Apply' button on filter only when values present. Fix #258.

turbot · Mar 12, 2024 · f32fdeb · f32fdeb
1 parent f1fe9a5
commit f32fdeb
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/ui/dashboard/src/components/dashboards/check/CheckFilterEditor/index.tsx b/ui/dashboard/src/components/dashboards/check/CheckFilterEditor/index.tsx
@@ -70,9 +70,9 @@ const validateFilter = (filter: CheckFilter): boolean => {
   }
 
   if (filter.operator === "equal") {
-    return (
-      !!filter.type && (filter.key !== undefined || filter.value !== undefined)
-    );
+    const noValue = filter.value === undefined || !filter.value?.trim();
+    if (noValue) return false;
+    return !!filter.type && (filter.key !== undefined || !noValue);
   }
 
   return false;