Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed table azure_compute_availability_set always returns null value for the column virtual_machines Closes #845 #856

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Fixed table azure_compute_availability_set always returns null value for the column virtual_machines Closes #845 #856

merged 3 commits into from
Nov 28, 2024
+68 −5

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented Nov 27, 2024

Integration test logs

Logs 
Add passing integration test logs here

Example query results

Results 
> select name, resource_group, virtual_machines from azure_compute_availability_set
+-------------------------+----------------+------------------------------------------------------------------------------------------------------------------------------------------------+
| name                    | resource_group | virtual_machines                                                                                                                               |
+-------------------------+----------------+------------------------------------------------------------------------------------------------------------------------------------------------+
| test-delete-me-if-found | demo           | <null>                                                                                                                                         |
| test-ved-delete-2       | demo           | [{"id":"/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/DEMO/providers/Microsoft.Compute/virtualMachines/TEST-VED-DELETE"}] |
+-------------------------+----------------+------------------------------------------------------------------------------------------------------------------------------------------------+

@ParthaI
Fixed azure_compute_availability_set always returns null value for th…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
14ed613 
…e column virtual_machines Closes #845
@ParthaI ParthaI requested a review from misraved November 27, 2024 11:40
@ParthaI ParthaI self-assigned this Nov 27, 2024
@ParthaI ParthaI linked an issue Nov 27, 2024 that may be closed by this pull request
azure_compute_availability_set returns Nulls #845
Closed
@ParthaI ParthaI changed the title Fixed azure_compute_availability_set always returns null value for the column virtual_machines Closes #845 Fixed table azure_compute_availability_set always returns null value for the column virtual_machines Closes #845 Nov 27, 2024
misraved
misraved reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@misraved misraved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParthaI I believe you need to make similar changes for the statuses column as well.

@ParthaI
Update the same for status column
Loading
Loading status checks…
fef21d8
@ParthaI
Update
Loading
Loading status checks…
e77d496
@misraved misraved merged commit 4a94ec5 into main Nov 28, 2024
1 check passed
@misraved misraved deleted the issue-845 branch November 28, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misraved misraved

Assignees

@ParthaI ParthaI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure_compute_availability_set returns Nulls
2 participants
@ParthaI @misraved