Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix epic_key column in list call. Closes #75 #80

Merged
merged 6 commits into from
Jun 14, 2023
Merged

Conversation

karanpopat
Copy link
Contributor

Example query results

Results
> select
  key,
  id, 
  epic_key,
  project_key
from
  jira_issue
where
  key in ('SBT-1', 'SBT-2', 'SBT-3')
+-------+-------+----------+-------------+
| key   | id    | epic_key | project_key |
+-------+-------+----------+-------------+
| SBT-3 | 10052 | SBT-1    | SBT         |
| SBT-1 | 10050 | <null>   | SBT         |
| SBT-2 | 10051 | SBT-1    | SBT         |
+-------+-------+----------+-------------+

Time: 396ms. Rows fetched: 1. Hydrate calls: 0.
> select
  key,
  id,
  epic_key,
  project_key
from
  jira_issue
where
  project_key = 'SBT'
+-------+-------+----------+-------------+
| key   | id    | epic_key | project_key |
+-------+-------+----------+-------------+
| SBT-3 | 10052 | SBT-1    | SBT         |
| SBT-1 | 10050 | <null>   | SBT         |
| SBT-2 | 10051 | SBT-1    | SBT         |
+-------+-------+----------+-------------+

Time: 0.9s. Rows fetched: 3. Hydrate calls: 3.

Copy link
Contributor

@misraved misraved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karanpopat thanks for looking into this issue 👍. I have left a minor review comment.

Also, do the APIs for ListConfig and GetConfig return similar data for the epic_key column?

Could you please add different example queries in the PR body to justify that both APIs return similar values?

jira/table_jira_issue.go Outdated Show resolved Hide resolved
@karanpopat
Copy link
Contributor Author

@misraved
Findings:

Have modified the list call in this PR to use the rest/api/2/search endpoint.

@misraved misraved merged commit 4058891 into main Jun 14, 2023
@misraved misraved deleted the issue_epic_key_fix branch June 14, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange result sets using epic_key in jira_issue table Inconsistent Behavior When Querying by Epic Key
2 participants