Mark Kendall #10
Open
Mark Kendall #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel the IC went well. Iterations 1-3 were very smooth, and I checked and re-checked that I all methods were returning appropriate data types, etc. Iteration 4 was much harder. The nested hash got very ugly quickly, and although the test is failing, I know I'm close by investigating the data in pry (which itself becomes very jumbled since so many actual objects - and therefore all of their data - are being displayed while nested). With a little more time, I feel good with iteration 4 as well.