Remove SN GADT in favour of inlinable functions #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In fact #323 isn't even needed for some of the speedups, it turns out. The simple |
turion
force-pushed
the
dev_sn_functions
branch
from
28c4854 to
2d9db23
Compare
turion
force-pushed
the
dev_sn_functions
branch
from
2d9db23 to
6d31812
Compare
turion
force-pushed
the
dev_sn_functions
branch
from
6d31812 to
8633007
Compare
turion
force-pushed
the
dev_sn_functions
branch
from
8633007 to
ba7a69d
Compare
turion
commented
Nov 27, 2024
turion
force-pushed
the
dev_sn_functions
branch
from
ba7a69d to
27d03a3
Compare
turion
force-pushed
the
dev_sn_functions
branch
from
27d03a3 to
745f23f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndrasKovacs suggested a great performance improvement that would allow more inlining. Instead of a recursive
SNtype that is erased at runtime, I can "functionalize" signal networks by encoding them directly in their semantic domain. Together with #323, this results in massive speedups.