Remove unnecessary reference counting from completion I/O callbacks #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PThorpe92
force-pushed
the
completion_rc
branch
from
4230bb4 to
72b423c
Compare
jussisaurio
approved these changes
Feb 7, 2025
penberg
changed the title
|
@PThorpe92 Love the mission! Looks like you self-conflicted your PR with 71d2a9b :) |
PThorpe92
force-pushed
the
completion_rc
branch
from
72b423c to
f1d889a
Compare
PThorpe92
force-pushed
the
completion_rc
branch
from
f1d889a to
7589802
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am on a bit of a mission to revisit a lot of the ref counting, this was an easy first win.
It seems to be a linear path of function calls or hashmaps which can own the completions directly, no cloning needed.