Skip to content

Commit

Permalink
[build] Remove getNapiRsLibrary.js again
Browse files Browse the repository at this point in the history
We need to put the library where the plugin expects to find it since it
does not work with native-cache
  • Loading branch information
charlag committed Jan 13, 2025
1 parent bcb6c98 commit 0c6fbca
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 54 deletions.
51 changes: 0 additions & 51 deletions buildSrc/getNapiRsLibrary.js

This file was deleted.

9 changes: 6 additions & 3 deletions ci/Desktop.Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,13 @@ pipeline {
}
steps {
bat "npm ci"
// building packages builds node-mimimi
bat "npm run build-packages"

bat "node buildSrc\\getNodeGypLibrary.js better-sqlite3 --copy-target better_sqlite3 --force-rebuild --root-dir ${WORKSPACE}"
powershell "node buildSrc\\getNapiRsLibrary.js \"@tutao/node-mimimi\" --dst-dir native-cache --root-dir ${WORKSPACE}"
stash includes: 'native-cache/**/*', name: 'native_modules'
// napi-rs rollup plugin expects .node for the package to be next to the entry point
// so we stash and unstash it as-is
stash includes: 'native-cache/**/*,packages/node-mimimi/dist/*.node', name: 'native_modules'
}
}
stage("Client") {
Expand All @@ -106,7 +108,8 @@ pipeline {
initBuildArea()

// nativeLibraryProvider.js placed the built native modules in the correct location (native-cache)
// so they will be picked up by our rollup plugin
// so they will be picked up by our rollup plugin.
//
unstash 'native_modules'

// add DEBUG for electron-builder because it tends to not let us know about things failing
Expand Down

0 comments on commit 0c6fbca

Please sign in to comment.