Fix broken canCreateEntity logic #8278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrb-hub
approved these changes
Jan 15, 2025
|
I'm wondering if this really should have a test. It wasn't tested before, and no tests were deleted (that I know of) when the refactor was done, especially regarding entity updates. |
If loading status is `Done`, then it is always OK to insert an entity. Also rename to canInsertEntity as it is not creating an entity but inserting one into the list. Lastly add tests for CREATE as they were missing. Fixes #8277 Co-authored-by: hrb-hub <[email protected]> Co-authored-by: charlag <[email protected]>
paw-hub
force-pushed
the
8277-new-emails-not-appearing
branch
from
d52d657 to
6d5bcac
Compare
charlag
approved these changes
Jan 16, 2025
|
My bad for misinterpreting the original code. The new tests will help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If loading status is
Done, then it is always OK to insert an entity.Also rename to canInsertEntity as it is not creating an entity but inserting one into the list.
Fixes #8277