clean up

Signed-off-by: tvallin <[email protected]>
tvallin · Sep 22, 2023 · 643f623 · 643f623
1 parent b6a088f
commit 643f623
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/archetype/engine-v2/src/main/java/io/helidon/build/archetype/engine/v2/ScriptLoader.java b/archetype/engine-v2/src/main/java/io/helidon/build/archetype/engine/v2/ScriptLoader.java
@@ -516,7 +516,6 @@ void addChild(State nextState, Node.Builder<? extends Node, ?> builder) {
         }
 
         Block.Kind blockKind() {
-            //TODO find a better option
             return Block.Kind.valueOf(qName.toUpperCase());
         }
 

diff --git a/archetype/engine-v2/src/main/java/io/helidon/build/archetype/engine/v2/Walker.java b/archetype/engine-v2/src/main/java/io/helidon/build/archetype/engine/v2/Walker.java
@@ -196,7 +196,7 @@ private class DelegateVisitor implements Node.Visitor<A>, Invocation.Visitor<A>
         @Override
         public VisitResult visitCondition(Condition condition, A arg) {
             VisitResult result = delegate.visitCondition(condition, arg);
-            if (result == VisitResult.CONTINUE && condition.then() != null) {
+            if (result == VisitResult.CONTINUE) {
                 stack.push(condition.then());
                 parents.push(condition);
                 traversing = true;

diff --git a/archetype/engine-v2/src/main/schema/archetype.xsd b/archetype/engine-v2/src/main/schema/archetype.xsd
@@ -83,7 +83,6 @@
         </xs:attribute>
     </xs:complexType>
 
-<!--    TODO : Should I use `condition` or `cond` ? -->
     <xs:attributeGroup name="condition-group">
         <xs:attribute type="xs:string" name="expr">
             <xs:annotation>
@@ -170,9 +169,6 @@
         </xs:sequence>
     </xs:group>
 
-<!--Suppress this-->
-<!--    -->
-
     <xs:complexType name="glob-type">
         <xs:annotation>
             <xs:documentation source="version">2.0</xs:documentation>