Fix issues related to title and html props #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that
react-tippy
wasn't working on IE11. I was getting this error message:Digging in, I discovered that this line seemed partly responsible: if the
title
prop isnull
, IE 11 sets the attribute to""
whereas all other browsers actually set the attribute to"null"
. IncreateTooltips
, this predicate looks for a truthytitle
attribute orhtml
setting. The predicate is essentially skipped for all browsers aside from IE 11 (unless""
was explicitly passed in as thetitle
) since"null"
is not falsy.The other problem with this predicate is that it is checking the
html
setting which does not seem to be the intent, since thehtml
prop is stored as thereactDOM
setting on this line. Also, thehtml
setting was introduced in this changeset line which does not touch the predicate increateTooltips
.These changes fix the IE 11 issue for me; they also do not affect the behavior in other browsers and the test app works.