Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve index.html content #222

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jun 5, 2023

This PR is heavily draft and is not ready for a full review yet. It is meant to be a starting point for discussion (/cc @mdo).

I find the current index.html content confusing as we explain that the user has succeeded to load the example with the default button rendering, but we also talk about a customized purple link (which on top of that is the default color of visited links). It's not that obvious IMO that we also customized some things in this example.

Screenshot 2023-06-05 at 18 32 03

The idea here is to have two separate sections:

  • the first one shows the default rendering of the button and the link
  • the second one shows that the danger color can be customized and that the link and button can be customized as well. Chose deep pink to show that obviously, something changed, and that is not the default color, nor comes from Bootstrap.

If this idea is good and accepted, all the other examples should be updated to follow this pattern.

@julien-deramond julien-deramond added the enhancement New feature or request label Jun 5, 2023
@julien-deramond julien-deramond force-pushed the main-jd-improve-bootstrap-examples-index-html-content branch from 301e519 to 589da78 Compare June 5, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant