Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cache, model): Member#joined_at can sometimes be null #2288

Merged
merged 3 commits into from
Oct 25, 2023
Merged

fix(cache, model): Member#joined_at can sometimes be null #2288

merged 3 commits into from
Oct 25, 2023

Conversation

kane50613
Copy link
Contributor

Discord's documentation shows that it should not be null, but it occasionally returns null.

I found another inactive pull request (#2276) so I made this one

@github-actions github-actions bot added c-cache Affects the cache crate c-model Affects the model crate labels Oct 20, 2023
@vilgotf vilgotf closed this Oct 20, 2023
@vilgotf vilgotf reopened this Oct 20, 2023
@HTGAzureX1212 HTGAzureX1212 changed the title Fix nullable joined_at field in member fix(cache, model): Member#joined_at can sometimes be null Oct 20, 2023
@github-actions github-actions bot added the t-fix Fixes a bug in the library label Oct 20, 2023
@HTGAzureX1212 HTGAzureX1212 enabled auto-merge (squash) October 20, 2023 10:52
@HTGAzureX1212 HTGAzureX1212 requested a review from a team October 20, 2023 10:53
@HTGAzureX1212
Copy link
Contributor

Reference PR: discord/discord-api-docs#6247

laralove143
laralove143 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@laralove143 laralove143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@HTGAzureX1212 HTGAzureX1212 merged commit 44752d1 into twilight-rs:main Oct 25, 2023
21 checks passed
@Gelbpunkt Gelbpunkt mentioned this pull request Nov 24, 2023
Closed
@Gelbpunkt Gelbpunkt mentioned this pull request Jan 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HTGAzureX1212 HTGAzureX1212 HTGAzureX1212 approved these changes

@laralove143 laralove143 laralove143 approved these changes

Assignees
No one assigned
Labels
c-cache Affects the cache crate c-model Affects the model crate t-fix Fixes a bug in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kane50613 @HTGAzureX1212 @laralove143 @vilgotf