Skip to content

Commit

Permalink
chore: update node to v20 (#3408)
Browse files Browse the repository at this point in the history
* chore: node update

* fix: core bundle build

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
  • Loading branch information
SiTaggart and kodiakhq[bot] authored Aug 14, 2023
1 parent 0d6f64b commit 32fd0eb
Show file tree
Hide file tree
Showing 11 changed files with 38 additions and 84 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/on_merge_to_main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ jobs:

- uses: nrwl/nx-set-shas@v3

- name: Setup Node.js 16.13
- name: Setup Node.js 20.5
uses: actions/setup-node@v3
with:
node-version: 16.13.x
node-version: 20.5.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down Expand Up @@ -85,10 +85,10 @@ jobs:

- uses: nrwl/nx-set-shas@v3

- name: Setup Node.js 16.13
- name: Setup Node.js 20.5
uses: actions/setup-node@v3
with:
node-version: 16.13.x
node-version: 20.5.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down Expand Up @@ -176,10 +176,10 @@ jobs:

- uses: nrwl/nx-set-shas@v3

- name: Setup Node.js 16.13
- name: Setup Node.js 20.5
uses: actions/setup-node@v3
with:
node-version: 16.13.x
node-version: 20.5.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down
40 changes: 20 additions & 20 deletions .github/workflows/on_pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:

- uses: nrwl/nx-set-shas@v3

- name: Setup Node.js 16.13
- name: Setup Node.js 20.5
uses: actions/setup-node@v3
with:
node-version: 16.13.x
node-version: 20.5.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down Expand Up @@ -67,10 +67,10 @@ jobs:

- uses: nrwl/nx-set-shas@v3

- name: Setup Node.js 16.13
- name: Setup Node.js 20.5
uses: actions/setup-node@v3
with:
node-version: 16.13.x
node-version: 20.5.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down Expand Up @@ -117,10 +117,10 @@ jobs:

- uses: nrwl/nx-set-shas@v3

- name: Setup Node.js 16.13
- name: Setup Node.js 20.5
uses: actions/setup-node@v3
with:
node-version: 16.13.x
node-version: 20.5.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down Expand Up @@ -167,10 +167,10 @@ jobs:

- uses: nrwl/nx-set-shas@v3

- name: Setup Node.js 16.13
- name: Setup Node.js 20.5
uses: actions/setup-node@v3
with:
node-version: 16.13.x
node-version: 20.5.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down Expand Up @@ -218,10 +218,10 @@ jobs:

- uses: nrwl/nx-set-shas@v3

- name: Setup Node.js 16.13
- name: Setup Node.js 20.5
uses: actions/setup-node@v3
with:
node-version: 16.13.x
node-version: 20.5.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down Expand Up @@ -269,10 +269,10 @@ jobs:

- uses: nrwl/nx-set-shas@v3

- name: Setup Node.js 16.13
- name: Setup Node.js 20.5
uses: actions/setup-node@v3
with:
node-version: 16.13.x
node-version: 20.5.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down Expand Up @@ -323,10 +323,10 @@ jobs:

- uses: nrwl/nx-set-shas@v3

- name: Setup Node.js 16.13
- name: Setup Node.js 20.5
uses: actions/setup-node@v3
with:
node-version: 16.13.x
node-version: 20.5.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down Expand Up @@ -393,10 +393,10 @@ jobs:
with:
fetch-depth: 0

- name: Setup Node.js 16.13
- name: Setup Node.js 20.5
uses: actions/setup-node@v3
with:
node-version: 16.13.x
node-version: 20.5.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down Expand Up @@ -449,10 +449,10 @@ jobs:
- name: Checkout Repo
uses: actions/checkout@v3

- name: Setup Node.js 16.13
- name: Setup Node.js 20.5
uses: actions/setup-node@v3
with:
node-version: 16.13.x
node-version: 20.5.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down Expand Up @@ -492,10 +492,10 @@ jobs:
- name: Checkout Repo
uses: actions/checkout@v3

- name: Setup Node.js 16.13
- name: Setup Node.js 20.5
uses: actions/setup-node@v3
with:
node-version: 16.13.x
node-version: 20.5.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/on_pull_request_cypress.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ jobs:
- name: Checkout Repo
uses: actions/checkout@v3

- name: Setup Node.js 16.13
- name: Setup Node.js 20.5
uses: actions/setup-node@v3
with:
node-version: 16.13.x
node-version: 20.5.x

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/on_pull_request_package_size.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:

- uses: nrwl/nx-set-shas@v3

- name: Setup Node.js 16.13
- name: Setup Node.js 20.5
uses: actions/setup-node@v3
with:
node-version: 16.13.x
node-version: 20.5.x

- uses: zahnster/[email protected]
with:
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16.13.0
v20.5.0
2 changes: 1 addition & 1 deletion internal-docs/engineering/developing-locally.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Before you begin there are some things that you will need to have installed, and
2. **[Xcode Command Line Tools](https://developer.apple.com/xcode/)** - Used to build some Apple software and node packages.
3. **[Homebrew](https://brew.sh/)** (optional)- A package manager for Mac software
1. Follow the installation instructions on the [Homebrew website](https://brew.sh/)
4. **NodeJS v16.13.x**- A JavaScript runtime for running JavaScript applications
4. **NodeJS v20.5.x**- A JavaScript runtime for running JavaScript applications
1. Node is preinstalled on Macs but you might need to manage the version that is installed.
5. **[NVM](https://github.com/nvm-sh/nvm)** (optional) - A Node version manager that can help installing and managing Node versions on your machine
1. Follow the [installation instructions on NVM](https://github.com/nvm-sh/nvm#installing-and-updating).
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"types": "./types/index.d.ts",
"engines": {
"node": "^16.13.0"
"node": "^20.5.0"
},
"scripts": {
"bootstrap": "",
Expand Down
1 change: 1 addition & 0 deletions packages/paste-core/core-bundle/tools/build-types.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#!/bin/bash
# Rather than compiling the types which end up taking a lot of time, we do this trick
# where we copy the src file as the type file (since they look the same in the end).
#
Expand Down
1 change: 1 addition & 0 deletions packages/paste-core/core-bundle/tools/clean-packages.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#!/bin/bash
# Removes all the built package folders and their package.json files.
#
# 1- Print the .gitignore file
Expand Down
1 change: 0 additions & 1 deletion packages/paste-website/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@
"react-visibility-sensor": "5.1.1",
"remark-gfm": "^3.0.1",
"rollbar": "^2.25.0",
"sharp": "^0.31.3",
"typescript": "^4.9.4",
"unist-util-visit-esm": "npm:unist-util-visit@^4.1.2",
"use-resize-observer": "^9.1.0",
Expand Down
53 changes: 3 additions & 50 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -16988,7 +16988,6 @@ __metadata:
react-visibility-sensor: 5.1.1
remark-gfm: ^3.0.1
rollbar: ^2.25.0
sharp: ^0.31.3
typescript: ^4.9.4
unist-util-visit-esm: "npm:unist-util-visit@^4.1.2"
use-resize-observer: ^9.1.0
Expand Down Expand Up @@ -22649,16 +22648,6 @@ __metadata:
languageName: node
linkType: hard

"color-string@npm:^1.9.0":
version: 1.9.1
resolution: "color-string@npm:1.9.1"
dependencies:
color-name: ^1.0.0
simple-swizzle: ^0.2.2
checksum: c13fe7cff7885f603f49105827d621ce87f4571d78ba28ef4a3f1a104304748f620615e6bf065ecd2145d0d9dad83a3553f52bb25ede7239d18e9f81622f1cc5
languageName: node
linkType: hard

"color-support@npm:^1.1.2, color-support@npm:^1.1.3":
version: 1.1.3
resolution: "color-support@npm:1.1.3"
Expand Down Expand Up @@ -22688,16 +22677,6 @@ __metadata:
languageName: node
linkType: hard

"color@npm:^4.2.3":
version: 4.2.3
resolution: "color@npm:4.2.3"
dependencies:
color-convert: ^2.0.1
color-string: ^1.9.0
checksum: 0579629c02c631b426780038da929cca8e8d80a40158b09811a0112a107c62e10e4aad719843b791b1e658ab4e800558f2e87ca4522c8b32349d497ecb6adeb4
languageName: node
linkType: hard

"colord@npm:^2.9.1":
version: 2.9.2
resolution: "colord@npm:2.9.2"
Expand Down Expand Up @@ -24466,7 +24445,7 @@ __metadata:
languageName: node
linkType: hard

"detect-libc@npm:^2.0.0, detect-libc@npm:^2.0.1":
"detect-libc@npm:^2.0.0":
version: 2.0.1
resolution: "detect-libc@npm:2.0.1"
checksum: ccb05fcabbb555beb544d48080179c18523a343face9ee4e1a86605a8715b4169f94d663c21a03c310ac824592f2ba9a5270218819bb411ad7be578a527593d7
Expand Down Expand Up @@ -36260,15 +36239,6 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"node-addon-api@npm:^5.0.0":
version: 5.1.0
resolution: "node-addon-api@npm:5.1.0"
dependencies:
node-gyp: latest
checksum: 2508bd2d2981945406243a7bd31362fc7af8b70b8b4d65f869c61731800058fb818cc2fd36c8eac714ddd0e568cc85becf5e165cebbdf7b5024d5151bbc75ea1
languageName: node
linkType: hard

"node-cleanup@npm:^2.1.2":
version: 2.1.2
resolution: "node-cleanup@npm:2.1.2"
Expand Down Expand Up @@ -39340,7 +39310,7 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"prebuild-install@npm:^7.0.1, prebuild-install@npm:^7.1.1":
"prebuild-install@npm:^7.0.1":
version: 7.1.1
resolution: "prebuild-install@npm:7.1.1"
dependencies:
Expand Down Expand Up @@ -42565,23 +42535,6 @@ resolve@^2.0.0-next.3:
languageName: node
linkType: hard

"sharp@npm:^0.31.3":
version: 0.31.3
resolution: "sharp@npm:0.31.3"
dependencies:
color: ^4.2.3
detect-libc: ^2.0.1
node-addon-api: ^5.0.0
node-gyp: latest
prebuild-install: ^7.1.1
semver: ^7.3.8
simple-get: ^4.0.1
tar-fs: ^2.1.1
tunnel-agent: ^0.6.0
checksum: 29fd1dfbc616c6389f53f366cec342b4353d9f2a37e98952ca273db38dca57dfa0f336322d6d763f0fae876042ead22fd86ffe26d70c32ade2458d421db60d04
languageName: node
linkType: hard

"shebang-command@npm:^1.2.0":
version: 1.2.0
resolution: "shebang-command@npm:1.2.0"
Expand Down Expand Up @@ -42704,7 +42657,7 @@ resolve@^2.0.0-next.3:
languageName: node
linkType: hard

"simple-get@npm:^4.0.0, simple-get@npm:^4.0.1":
"simple-get@npm:^4.0.0":
version: 4.0.1
resolution: "simple-get@npm:4.0.1"
dependencies:
Expand Down

0 comments on commit 32fd0eb

Please sign in to comment.