fix: combobox inside of popover bug #4049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 09d9390 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
bot
added
the
size:L
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
the
Area: Components
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 09d9390. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
Size Change: +72 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
fix/combobox-in-popover
|
| Run status |
|
| Run duration | 01m 59s |
| Commit |
|
| Committer | “nora |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
67
|
| View all changes introduced in this branch ↗︎ | |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 09d9390:
|
nkrantz
force-pushed
the
fix/combobox-in-popover
branch
from
2683de1 to
09d9390
Compare
github-actions
bot
added
Type: Documentation
krisantrobus
approved these changes
Aug 29, 2024
serifluous
approved these changes
Aug 29, 2024
nkrantz
added
the
🕵🏻♀️ Run website visual regression
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
fix/combobox-in-popover
|
| Run status |
|
| Run duration | 06m 01s |
| Commit |
|
| Committer | Nora Krantz |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where Comboboxes (Singleselect and Multiselect) can't be used when placed inside of Popovers. The bug was caused by the Combobox Listbox Portal interfering with the Popover Reakit Portal, and was preventing hover styles from being applied as well as closing the entire Popover on a selection of an item (Multiselect only). See this CodeSandbox for a reproduction and more context.
This PR adds the
usePortalprop to Combobox (which defaults totrue). It should be used (and set tofalse) when Combobox is used in a Popover. When Combobox doesn't use a Portal, it uses an absolutely positioned Box to position the listbox and attach it to the input box. This means that the ListboxPositioner isn't used on these Comboboxes, so the listbox won't position itself above the input box when the input is at the bottom of the window. If this bug comes up it will be addressed in the future.Examples added to Singleselect and Multiselect Combobox docs.