feat(tooltip): add keyboard shortcuts to tooltip #4161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serifluous
reviewed
Nov 15, 2024
serifluous
reviewed
Nov 15, 2024
serifluous
reviewed
Nov 15, 2024
Co-authored-by: Sarah <[email protected]>
nkrantz
reviewed
Nov 19, 2024
nkrantz
reviewed
Nov 19, 2024
Co-authored-by: Nora Krantz <[email protected]>
nkrantz
approved these changes
Nov 19, 2024
roxanagomez
approved these changes
Nov 19, 2024
krisantrobus
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
add-keyboard-keys-to-tooltip
|
| Run status |
|
| Run duration | 06m 14s |
| Commit |
|
| Committer | krisantrobus |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to put keyboard actions into tooltip. This works by changing the props Tooltip can accept. It will no accept two types with no overlap. This means when you try to pass text to the component along with types from the
KeyboardKeyTooltipPropsyou will get a typescript error. Also added a failsafe check if developers try to ignore it or attempt to break it in anyway.