-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): replace legacy blockquotes with component #4178
Conversation
Run & review this pull request in StackBlitz Codeflow. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 340b5ce. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
numbers (such as 10 and 20), users might as well click the Next Page button rather than suffer the cognitive | ||
overhead of trying to decide their display preference. | ||
</BlockquoteContent> | ||
<BlockquoteCitation author="Nielsen Norman Group" source={`Users' Pagination Preferences and "View All"`} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the source and author as other quotes form this website use the group as the author. Changed for consistency across the site
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 340b5ce:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! let's also remove the old codeblock component since we don't need it anymore.
080d0f6
to
dfbb4c2
Compare
Paste Run #9128
Run Properties:
|
Project |
Paste
|
Branch Review |
replace-docs-blockquotes
|
Run status |
Passed #9128
|
Run duration | 02m 08s |
Commit |
340b5cec00: Merge branch 'main' into replace-docs-blockquotes
|
Committer | Nora Krantz |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
67
|
View all changes introduced in this branch ↗︎ |
Paste Run #9127
Run Properties:
|
Project |
Paste
|
Branch Review |
replace-docs-blockquotes
|
Run status |
Passed #9127
|
Run duration | 05m 57s |
Commit |
c6442c1acb ℹ️: Merge 340b5cec00bcbfdd07afbc0a6a310c32e3bfda01 into 932a03f2313f6a743729bd19e822...
|
Committer | krisantrobus |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
125
|
View all changes introduced in this branch ↗︎ |
No description provided.