feat(assistant): assistant improvements #4214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
size:L
github-actions
bot
added
Type: Documentation
|
View your CI Pipeline Execution ↗ for commit eb848b2.
☁️ Nx Cloud last updated this comment at |
|
Size Change: +5.48 kB (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit eb848b2:
|
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
chore-remoce-slack-integration-local
|
| Run status |
|
| Run duration | 01m 58s |
| Commit |
|
| Committer | Kristian Antrobus |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
67
|
| View all changes introduced in this branch ↗︎ | |
krisantrobus
changed the title
krisantrobus
commented
Jan 22, 2025
| @@ -3,7 +3,7 @@ import React from "react"; | |||
|
|
|||
| const Window: React.FC<React.PropsWithChildren> = ({ children }) => { | |||
| return ( | |||
| <Box display="grid" gridTemplateColumns="400px 1fr" height="100svh" width="100%"> | |||
| <Box display="grid" gridTemplateColumns="300px 1fr" height="100svh" width="100%"> | |||
There was a problem hiding this comment.
Found this was taking too much space on medium displays
krisantrobus
commented
Jan 22, 2025
| <AIChatMessageBody {...props}> | ||
| {threadMessage.content.length > 0 && | ||
| threadMessage.content[0]?.type === "text" && | ||
| compiler(threadMessage.content[0].text.value, assistantMarkdownOptions)} |
There was a problem hiding this comment.
Had to use compiler because the animated children was causing the component in the library to throw errors. I also added some information to our docs for how to overcome this.
krisantrobus
commented
Jan 22, 2025
| @@ -15,7 +24,7 @@ export const UserMessage: React.FC<{ threadMessage: Message }> = ({ threadMessag | |||
| > | |||
| You | |||
| </AIChatMessageAuthor> | |||
| <AIChatMessageBody> | |||
| <AIChatMessageBody {...props}> | |||
There was a problem hiding this comment.
Changed so we can pass in props for the body, for this one the size="fullScreen"
krisantrobus
commented
Jan 22, 2025
| @@ -24,7 +24,7 @@ const Assistant: NextPage = () => { | |||
| /> | |||
| </Head> | |||
| <AssistantPage /> | |||
| <ReactQueryDevtools initialIsOpen={false} /> | |||
| <ReactQueryDevtools initialIsOpen={false} buttonPosition="bottom-left" /> | |||
There was a problem hiding this comment.
The developer floating button (the palm trees button when running locally) was covering the submit button on chat composer so moved the positioning
krisantrobus
commented
Jan 22, 2025
| )} | ||
| <AIChatMessageBody {...props}> | ||
| {threadMessage.content.length > 0 && | ||
| threadMessage.content[0]?.type === "text" && |
There was a problem hiding this comment.
The Vercel issue where it would sometimes throw the 500 Sarah was talking about was due to deleting a thread the threadMessage.content[0] was undefined and threw a 500 that type could not be found.
PixeledCode
previously approved these changes
Jan 23, 2025
|
lgtm 🚀 |
roxanagomez
reviewed
Jan 27, 2025
nkrantz
reviewed
Jan 28, 2025
| @@ -49,21 +55,25 @@ export const AssistantComposer: React.FC<{ onMessageCreation: (message: string, | |||
| throw error; | |||
| }, | |||
| }} | |||
| disabled={isLoading} | |||
There was a problem hiding this comment.
question: not necessarily a change for this PR, but do you remember why we didn't add cursor: not-allowed to the whole Chat Composer Container?
There was a problem hiding this comment.
Uh no I don't remember discussing that sorry. We can start a new thread for it in Slack though if you want.
nkrantz
reviewed
Jan 28, 2025
| setIsAnimating(true); | ||
| }; | ||
|
|
||
| const userScrolled = (): void => setUserInteractedScroll(true); |
nkrantz
reviewed
Jan 28, 2025
| key={threadMessage.id} | ||
| threadMessage={threadMessage} | ||
| // Only animate the last message recieved from AI and must be most recent run to avoid reanimating | ||
| animated={index === messages.length - 1 && lastActiveRun?.id === threadMessage.run_id} |
There was a problem hiding this comment.
question: if the user sends another prompt before the currently animating response is finished animating, sometimes 2 responses end up animating at the same time. probably wouldn't happen super regularly, but in that case, would we want to stop animating the first response, display the whole thing, and only animate one (most recent) response at a time?
There was a problem hiding this comment.
Yea, we need the stop animating functionality on the component. Right now we just have animating hooks. @roxanagomez will be including it in the V2 and we should add that logic in.
There was a problem hiding this comment.
gotcha, didn't realize we had also talked about stop animating in the case when 2 messages were animating at the same time. cool!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added various improvements to the Paste AI Assistant.