Fix evergreen shadow borders and font-size-40 #4220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serifluous
commented
Jan 24, 2025
serifluous
commented
- Adds back evergreen shadow borders
- Adds back font-size-40 in evergreen
|
|
🦋 Changeset detectedLatest commit: 56e84d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
bot
added
the
size:M
serifluous
changed the title
github-actions
bot
added
Area: Tokens
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 56e84d7.
☁️ Nx Cloud last updated this comment at |
|
Size Change: +75 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
fix-evergreen-shadow-borders
|
| Run status |
|
| Run duration | 01m 58s |
| Commit |
|
| Committer | Kristian Antrobus |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
67
|
| View all changes introduced in this branch ↗︎ | |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 56e84d7:
|
dosubot
bot
added
size:L
github-actions
bot
added
Area: Storybook
| @@ -248,6 +248,30 @@ export const decorators = [ | |||
| </Box> | |||
| </Box> | |||
| </Theme.Provider> | |||
| <Theme.Provider theme="evergreen" disableAnimations customBreakpoints={breakpoints}> | |||
There was a problem hiding this comment.
Added in evergreen so we can catch theme updates in our snapshots to avoid unnecessary breaking changes.
krisantrobus
previously approved these changes
Jan 24, 2025
github-actions
bot
added
the
Area: Components
| </Tr> | ||
| </THead> | ||
| <TBody> | ||
| {[...new Array(5).keys()].map((index) => ( |
There was a problem hiding this comment.
This resolves the chromatic max height issue when adding the new theme to stacked view:
Wrapping the component in a scrollable Box still allows the sticky header to be tested.
krisantrobus
previously approved these changes
Jan 27, 2025
nkrantz
previously approved these changes
Jan 28, 2025
Comment on lines
+2
to
+3
| "@twilio-paste/design-tokens": patch | ||
| "@twilio-paste/core": patch |
There was a problem hiding this comment.
Added a patch as technically we are fixing tokens not adding anything new
|
|
||
| # primary | ||
| color-text-primary: | ||
| value: "#3366FF" |
There was a problem hiding this comment.
@serifluous we hardcoded this value as most other values (including the color-text-link) are hardcoded. No aliases are actually being used. The ones in the alias for palette-blue-60 aren't being referenced. Should we be using aliases in these themes? Would need another refactor if so.
There was a problem hiding this comment.
Originally, they should've been, but at this point, we're just leaving them as hex codes
krisantrobus
approved these changes
Jan 28, 2025
nkrantz
approved these changes
Jan 28, 2025
nkrantz
added
the
🕵🏻♀️ Run website visual regression
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
fix-evergreen-shadow-borders
|
| Run status |
|
| Run duration | 05m 55s |
| Commit |
|
| Committer | Sarah |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.