Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RequestValidator to use getRawPath, getRawQuery() and getRawFragment() #823

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
changed RequestValidator updatePort() to use raw Query, raw Path and …
…raw Fragment
  • Loading branch information
bhaskar16 committed Nov 18, 2024
commit a50e2579d75bf0708e17e8e58a69158944715794
6 changes: 3 additions & 3 deletions src/main/java/com/twilio/security/RequestValidator.java
Original file line number Diff line number Diff line change
@@ -141,9 +141,9 @@ private String updatePort(URI url, int newPort) {
url.getUserInfo(),
url.getHost(),
newPort,
url.getPath(),
url.getQuery(),
url.getFragment()).toString();
url.getRawPath(),
url.getRawQuery(),
url.getRawFragment()).toString();
} catch (Exception e) {
return url.toString();
}
15 changes: 15 additions & 0 deletions src/test/java/com/twilio/security/RequestValidatorTest.java
Original file line number Diff line number Diff line change
@@ -114,4 +114,19 @@ public void testValidateAddsPortHttp() {
Assert.assertTrue("Validator did not add port 80 to http url", isValid);
}

@Test
public void testValidateRemovesPortHttpsWithSpecialParams() {
String url = "https://mycompany.com/myapp.php";
String param = "?param1=client%3AAnonymous";
url = url + param;
boolean isValid = validator.validate(url, params, "iQIea/lNtwezVhrpQ/KiGTEmJDA=");

Assert.assertTrue("Validator did not strip port from url", isValid);

url = url.replace(".com", ".com:1234");
isValid = validator.validate(url, params, "g7dthJtIvMAeMJ8XhiywDKG63Gg=");

Assert.assertTrue("Validator did not strip port from url", isValid);
}

}