feat: update generator to support making a JSON POST request from the Go SDK #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SDK changes twilio/twilio-go#84 |
|
The PR job is failing due to dockerhub rate limits |
thinkingserious
added
status: code review request
shwetha-manvinkurke
added
status: work in progress
|
Hello @RJPearson94! This PR has come up for review, could you please resolve the merge conflicts? Thank you!! Also, there are merge conflicts for twilio/twilio-go#84 and twilio/twilio-go#83. Thank you and apologies for the delayed response. |
thinkingserious
added
status: waiting for feedback
…JSON media type for the request body The Go Generator has been updated to add a vendor extension to set `x-is-json` to true when the consume media type is `application/json` and `x-is-form` when the consumes media type is `application/x-www-form-urlencoded` The `x-is-json` vendor extension is used to generate the code to handle calling the new PostJson function or the corresponding HTTP method function on the request handler. This is designed to only work with Post requests at the moment but could be extended in the future if needed. This PR aids in resolving twilio#49 however once this PR is merged twilio/twilio-oai#36 will need to be finished to fully resolve the issue This change relies on twilio/twilio-go#83 and the tests cannot be updated until this PR is merged and released This change also fixes an issue with JSON struct tags for the Params structs being `html-escaped`. I have disabled the escaping by using `{{{}}}` as this was highlighted during linting the Go SDK repo
RJPearson94
force-pushed
the
add-json-support
branch
from
f6d46b3 to
25cbb8b
Compare
|
Hey @thinkingserious, Thanks for getting back to me and no need to apologise for the delay, I appreciate you taking the time to look at these. All 3 PR's have now been updated to resolve any merge conflicts. |
shwetha-manvinkurke
added
status: work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go Generator has been updated to add a vendor extension to set
x-is-jsonto true when the consumes media type isapplication/jsonandx-is-formwhen the consumes media type isapplication/x-www-form-urlencodedThe
x-is-jsonvendor extension is used to generate the code to handle calling the new PostJson function or the corresponding HTTP method function on the request handler. This is designed to only work with Post requests at the moment but the request handler could be extended in the future if needed.This PR aids in resolving #49 however once this PR is merged twilio/twilio-oai#36 will need to be finished to fully resolve the issue
This change relies on twilio/twilio-go#83 and the tests cannot be updated until this PR is merged and released
This change also fixes an issue with JSON struct tags for the Params structs being
html-escaped. I have disabled the escaping by using{{{ }}}as this was highlighted during linting the Go SDK repoChecklist
make test-dockerpython examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-goand inspect the diffmake testintwilio-gotwilio-goIf you have questions, please create a GitHub Issue in this repository.