chore: add required query param in read operations php #631
Conversation
|
PHP preview PR - twilio/twilio-php#842 |
| @@ -89,6 +89,24 @@ | |||
| {{/vendorExtensions.x-serialize-map}} | |||
| {{/vendorExtensions.x-serialize}} | |||
| {{/vendorExtensions.optionFileParams}} | |||
| {{#queryParams.0}} | |||
There was a problem hiding this comment.
verify with multiple required query parameters.
|
|
|
|
|
Verified the following cases of objects and maps. In PHP, Object implies dataTypes like date and bool. While all lists and maps are treated as Example spec: {
"name": "AccountSid",
"in": "query",
"description": "The SID of the [Account](https://www.twilio.com/docs/iam/api/account) that created the Payments resource.",
"schema": {
"type": "string",
"minLength": 34,
"maxLength": 34,
"pattern": "^AC[0-9a-fA-F]{32}$"
},
"required": true,
"examples": {
"readEmpty": {
"value": "ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
},
"readFull": {
"value": "ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
}
}
},
{
"name": "MessageDate",
"in": "query",
"description": "Only show notifications for the specified date, formatted as `YYYY-MM-DD`. You can also specify an inequality, such as `<=YYYY-MM-DD` for messages logged at or before midnight on a date, or `>=YYYY-MM-DD` for messages logged at or after midnight on a date.",
"schema": {
"type": "string",
"format": "date"
},
"examples": {
"readFull": {
"value": "2008-01-02"
},
"readEmpty": {
"value": "2008-01-02"
}
}
},
{
"name": "ListOfNames",
"in": "query",
"description": "A comma-separated list of the names of the keys to retrieve.",
"schema": {
"type": "array",
"items": {
"type": "string"
}
},
"examples": {
"readFull": {
"value": ["foo", "bar"]
},
"readEmpty": {
"value": ["foo", "bar"]
}
}
},Generated code in PHP: 'MessageDate' =>
Serialize::iso8601Date($options['messageDate']),
'ListOfNames' =>
Serialize::map($options['listOfNames'], function ($e) { return $e; }),
'AccountSid' =>
$options['accountSid'], |
Fixes #DI-1676
Add required query params in read operation for PHP.
Verified that this issue is only in PHP and not in any other language.
Review PR for php: twilio/twilio-php#842 [Do not merge]
Checklist
make test-dockerpython examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-goand inspect the diffmake testintwilio-phptwilio-phpIf you have questions, please create a GitHub Issue in this repository.