Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAS-16 - Gradle Updated for Build JS Lib #32

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

CAS-16 - Gradle Updated for Build JS Lib #32

wants to merge 5 commits into from

Conversation

kmorope
Copy link

@kmorope kmorope commented Aug 23, 2024

Ticket

  • [CAS-16]

Description

  • Updated Gradle for build JS from commonMain lib based on Demo code

Testing

  • Added unit tests
  • Ran unit tests successfully
  • Added documentation for public APIs and/or Wiki

@kmorope kmorope requested a review from a team as a code owner August 23, 2024 01:50
import kotlinx.serialization.json.Json
import kotlin.js.Promise

@JsModule("./CredentialManager")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ The class CredentialManager only contains utility functions. Consider defining it as an object.

@JsExport
@JsName("TwilioPasskeys")
class TwilioPasskeysJS private constructor(
private val credentialManager: CredentialManager.Companion,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Private property credentialManager is unused.

@authid-sdk-ci
Copy link
Contributor

1 Error
🚫 Detekt found some warnings, try to fix them

Generated by 🚫 Danger

@authid-sdk-ci
Copy link
Contributor

24 Errors
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L31: Expected a blank line for this declaration
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L35: Needless blank line(s)
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L37: Missing trailing comma before ")"
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L39: Class body should not start with blank line
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L41: Missing trailing comma before ")"
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L46: Missing trailing comma before ")"
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L51: Newline expected after opening parenthesis
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L51: Parameter should start on a newline
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L51: Newline expected before closing parenthesis
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L57: Missing trailing comma before ")"
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L64: Missing trailing comma before ")"
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L70: Needless blank line(s)
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L76: Missing trailing comma before ")"
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L78: Class body should not start with blank line
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L82: Missing trailing comma before ")"
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L85: Needless blank line(s)
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L93: Needless blank line(s)
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L96: Missing trailing comma before ")"
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L99: Missing spacing after ","
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L103: No whitespace expected between opening parenthesis and first parameter name
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L103: No whitespace expected between last parameter and closing parenthesis
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L111: Newline expected after opening parenthesis
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L111: Parameter should start on a newline
🚫 shared/src/jsMain/kotlin/com/twilio/passkeys/TwilioPasskeys.kt#L111: Newline expected before closing parenthesis

Generated by 🚫 Danger

@authid-sdk-ci
Copy link
Contributor

1 Warning
⚠️

Size impact

ABI APK Size Impact
x86 2MB
x86_64 2MB
armeabi-v7a 2MB
arm64-v8a 2MB
universal 2MB

Generated by 🚫 Danger

@authid-sdk-ci
Copy link
Contributor

🧛 shared module Code Coverage: 96.16%

Coverage of Modified Files:

File Coverage
TwilioPasskeys.kt 97.38%

Modified Files Not Found In Coverage Report:

CredentialManager.js
build.gradle.kts
build.gradle.kts
index.html
yarn.lock

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@authid-sdk-ci
Copy link
Contributor

1 Warning
⚠️ IPA size: 1.9 MB
App size: 6.6 MB
TwilioPasskeysAuthentication.framework: 5.6 MB, Impact: 84.4%

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants