Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FLEXIN-74: changed endpoints for init and token refresh #46

Merged
merged 28 commits into from
Oct 17, 2023
Merged

FLEXIN-74: changed endpoints for init and token refresh #46

merged 28 commits into from
Oct 17, 2023

Conversation

ashishkumarTWLO
Copy link
Collaborator

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@ashishkumarTWLO ashishkumarTWLO marked this pull request as ready for review August 8, 2023 12:27
AnudeepChPaul
AnudeepChPaul reviewed Aug 9, 2023
View reviewed changes
.env.sample Outdated Show resolved Hide resolved
AnudeepChPaul
AnudeepChPaul requested changes Aug 9, 2023
View reviewed changes
src/__tests__/index.test.tsx Outdated Show resolved Hide resolved
src/__tests__/index.test.tsx Outdated Show resolved Hide resolved
src/__tests__/sessionDataHandler.test.ts Show resolved Hide resolved
src/sessionDataHandler.ts Outdated Show resolved Hide resolved
AnudeepChPaul
AnudeepChPaul requested changes Aug 9, 2023
View reviewed changes
src/sessionDataHandler.ts Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

AnudeepChPaul
AnudeepChPaul requested changes Aug 11, 2023
View reviewed changes
.eslintrc Show resolved Hide resolved
@ashishkumarTWLO
Merge branch 'flex-webchat-ui' into FLEXIN-74
00df233 
# Conflicts:
#	src/__tests__/index.test.tsx
#	src/__tests__/sessionDataHandler.test.ts
#	src/index.tsx
@ashishkumarTWLO
FLEXIN-74: replaced console with logger framework
15bd19e
mdeshpande12
mdeshpande12 requested changes Aug 18, 2023
View reviewed changes
src/utils/regionUtil.test.ts Outdated Show resolved Hide resolved
src/__tests__/sessionDataHandler.test.ts Show resolved Hide resolved
mdeshpande12
mdeshpande12 previously approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@mdeshpande12 mdeshpande12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@ashishkumarTWLO
FLEXIN-74: POC changes 2
ee17eba
@ashishkumarTWLO
FLEXIN-74: POC changes 3
b7139ac
@ashishkumarTWLO
Merge branch 'flex-webchat-ui' into FLEXIN-74
7465863 
# Conflicts:
#	.env.sample
#	public/index.html
#	src/components/PreEngagementFormPhase.tsx
#	src/components/WebchatWidget.tsx
#	src/definitions.ts
#	src/index.tsx
#	src/sessionDataHandler.ts
#	src/store/actions/initActions.ts
#	src/store/definitions.ts
#	src/utils/generateSecurityHeaders.test.ts
#	src/utils/generateSecurityHeaders.ts
#	src/utils/regionUtil.test.ts
#	src/utils/regionUtil.ts
@ashishkumarTWLO
FLEXIN-74: corrections after merge conflicts
5fca1f7
@ashishkumarTWLO
Merge branch 'flex-webchat-ui' into FLEXIN-74
6fc69be 
# Conflicts:
#	public/index.html
@ashishkumarTWLO
FLEXIN-74: fixing unit tests
ba6e1ba
@ashishkumarTWLO
FLEXIN-74: fixing unit tests
80cc23d
@ashishkumarTWLO
FLEXIN-74: more fixing
d757719
AnudeepChPaul
AnudeepChPaul previously approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@AnudeepChPaul AnudeepChPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this PR as it's a time limited requirement. However, we need to take care of these comments.
Let's have a story to handle these.

src/__tests__/sessionDataHandler.test.ts Show resolved Hide resolved
src/sessionDataHandler.ts Show resolved Hide resolved
src/sessionDataHandler.ts Show resolved Hide resolved
@ashishkumarTWLO
Merge remote-tracking branch 'origin/flex-webchat-ui' into FLEXIN-74
8db9c5f 
# Conflicts:
#	src/__tests__/index.test.tsx
#	src/index.tsx
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

84.0% 84.0% Coverage
0.0% 0.0% Duplication

mdeshpande12
mdeshpande12 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@mdeshpande12 mdeshpande12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashishkumarTWLO ashishkumarTWLO merged commit 8696e30 into flex-webchat-ui Oct 17, 2023
@ashishkumarTWLO ashishkumarTWLO deleted the FLEXIN-74 branch October 17, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnudeepChPaul AnudeepChPaul AnudeepChPaul approved these changes

@mdeshpande12 mdeshpande12 mdeshpande12 approved these changes

@yukta23 yukta23 yukta23 approved these changes

@vinesh-kumar vinesh-kumar Awaiting requested review from vinesh-kumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ashishkumarTWLO @AnudeepChPaul @yukta23 @vinesh-kumar @mdeshpande12