Add Router instead of server #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagikazarmark
added
kind/enhancement
sagikazarmark
force-pushed
the
add-router
branch
from
c92d107 to
165d03e
Compare
sagikazarmark
force-pushed
the
add-router
branch
from
165d03e to
bad5b98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add a new Router that replaces Server.
What this PR does / why we need it
We will likely want to use the name Server for something else.
Also, Router uses more generic terms as path (instead of prefix) and handler (instead of server).
Related #88
Related #89
Special notes for your reviewer
Does this PR introduce a user-facing change?