Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust CSS for adds injected by ReadTheDocs #829

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

tristanlatr
Copy link
Contributor

Fix #828

The current rendering of the page is pretty bad: https://docs.twisted.org/en/twisted-24.7.0/api/index.html

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.29%. Comparing base (4114a51) to head (ffa9edd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #829   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files          47       47           
  Lines        8514     8514           
  Branches     1695     1695           
=======================================
  Hits         7858     7858           
  Misses        385      385           
  Partials      271      271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

…ve the UX (because the main div is somewhat more in the middle of the screen because the sidebare takes the left side of the screen) as well as give more chances to the reader not to be bothered by the overlapping readthedocs add that is injected at a fixed point bottom right of the screen.
README.rst Outdated Show resolved Hide resolved

This comment has been minimized.

This comment has been minimized.

Copy link

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

@tristanlatr tristanlatr merged commit bc101b4 into master Oct 25, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The readthedocs theme CSS is not compatible with the new readthedocs adds
1 participant