Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LzoBinaryBlockRecordReader bug: skip bad block rather than throws IOE #476

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix LzoBinaryBlockRecordReader bug: skip bad block rather than throws IOE #476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions core/src/main/java/com/twitter/elephantbird/mapreduce/input/LzoBinaryBlockRecordReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,13 @@ public boolean nextKeyValue() throws IOException, InterruptedException {
// As a consequence of this, next split reader skips at least one byte
// (i.e. skips either partial or full record at the beginning).
}
byte[] byteArray = reader_.readNextProtoBytes();

byte[] byteArray = null;
try {
byteArray = reader_.readNextProtoBytes();
} catch (IOException ioe){
// catch IOE, rather than throw it
LOG.error("Error reading split, skip it. ", ioe);
}
if(byteArray == null) {
return false;
}
Expand Down