-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused variables #1813
base: main
Are you sure you want to change the base?
Remove unused variables #1813
Conversation
LGTM |
Next time, keep in mind it is usually better to keep the git history clean. Your commit shows that the whole section was deleted then re-added. I guess its fine for now. lgtm |
That is because he moved the whole code section on step further to the right, instead of just editing the values that needed to be edited. @mzarchi i recommend fixing your broken code indentation so the twitter devs have a proper change diff. |
Ok, thanks for it ❤️ |
Be sure and thanks for the beauty point you said ❤️ |
LGTM |
There were two variables in the code that were used only once, out of respect for Twitter developers, I removed this variable and entered the values directly into dict.