Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes from recent Twitter personal data export #578

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sloanlance
Copy link

Changed images from my recent personal Twitter data export. It seems to be mostly changes in color, brightness, size (e.g., flag aspect ratios), and apparently the gender of some people emoji. I'm not sure which is newer, the ones from Twitter's twemoji repo or the ones in my export.

Changed images from my recent personal Twitter data export.  It seems to be mostly changes in color, brightness, size (e.g., flag aspect ratios), and apparently the gender of some people emoji.  I'm not sure which is newer, the ones from Twitter's twemoji repo or the ones in my export.
@CLAassistant
Copy link

CLAassistant commented Dec 13, 2022

CLA assistant check
All committers have signed the CLA.

@keithbroni
Copy link

These emoji designs appear to be from the Twemoji 2.x sets, before the introduction of the gender neutral orange colour scheme.

@sloanlance
Copy link
Author

@keithbroni, you think the changes shown in this PR are the old versions, then?

If so, that's unfortunate. Twitter shouldn't send the old images as part of the data exports. The old images shouldn't be in active use anywhere, for that matter.

@bhaggs
Copy link
Contributor

bhaggs commented Dec 13, 2022

It's been awhile since I worked at/on Twitter/Twemoji--the data export is meant to behave as a complete free standing archive of your Twitter data that can function without a connection to the internet or assets hosted elsewhere. As such, the Twemoji library is bundled with the data export. The version bundled is a bit out of date. This is likely due to that when the data export tool was developed/last worked on, that was the current version of Twemoji at the time and to ensure the tool doesn't break over time due to future changes in Twemoji, it is not automatically updated to the latest version.

Since your archive is self contained, if you really wanted to update your local archive to use the latest Twemoji you could at a minimum swap out the twemoji assets (assets/images/twemoji) for the latest versions. To update the parsing of new emoji characters may take more effort to swap out the emoji parsing js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants