Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using mbuf after returning it to mbuf free list for redis mset. #461

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

huachaohuang
Copy link

No description provided.

@andyqzb
Copy link
Contributor

andyqzb commented Aug 26, 2016

I merge the bugfix in #486 , but using mbuf_length on a mbuf is not a good way after putting the mbuf to the free list. So can you create a new pr based on the master, I want to merge your code.

@@ -1,3 +1,3 @@
language: c
script: bash ./travis.sh

sudo: required
Copy link
Contributor

@andyqzb andyqzb Aug 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the intention of this line?

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@TysonAndre
Copy link
Collaborator

I merge the bugfix in 486 , but using mbuf_length on a mbuf is not a good way after putting the mbuf to the free list. So can you create a new pr based on the master, I want to merge your code.

My understanding of this: twemproxy is single threaded so it doesn't cause issues in practice, but would agree in principle (e.g. if mbuf_free were to be replaced with an actuall free call as a debug compile option to debug memory leaks or use-after free)

@TysonAndre TysonAndre changed the title Fix memory leak for redis mset. Fix using mbuf after returning it to mbuf free list for redis mset. Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants