Remove metatransaction.core import that causes problem with mount. #1691
Conversation
# Conflicts: # scheduler/src/cook/quota.clj
scheduler/src/cook/components.clj
Outdated
| ; If you get an error about "Can't embed object in code, maybe print-dup not defined: clojure.lang.Delay" | ||
| ; The issue is about metatransaction.core seems to be incompatible with mount. It cannot be in the dependency tree. |
There was a problem hiding this comment.
This comment seems overly specific in blaming metatransaction.core for the error. What if we have another namespace that causes the same error when require'd into the dependency tree? How did you trace the blame back to metatransaction.core? The first sentence on 343 has a typo, so it needs to be reworded anyway.
Maybe just mention the error and link to issue #1370 instead. I probably should have done something like that when I opened the issue.
There was a problem hiding this comment.
I was able to create the error only adding a dependency to metatransaction.core, and was able to make it go away by deleting the reference. The issue you found adding progress was because of this dependency chain: cook.progress -> cook.tools -> metatransaction.core. I reworded it.
Changes proposed in this PR
Why are we making these changes?
Avoids an incomprehensible error with mount. Diagnoses #1370 with a workaround.