fix: json deserialization from payload fails with i128 is not supported #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarmuega
reviewed
Oct 6, 2023
scarmuega
approved these changes
Oct 7, 2023
scarmuega
deleted the
709-json-deserialization-from-payload-fails-with-i128-is-not-supported
branch
W95Psp
pushed a commit
to hacspec/hax
that referenced
this pull request
Jun 30, 2024
See serde-rs/json#625. This patch is highly inspired by txpipe/oura#712.
W95Psp
pushed a commit
to hacspec/hax
that referenced
this pull request
Jul 1, 2024
See serde-rs/json#625. This patch is highly inspired by txpipe/oura#712.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #709
As json does not support i128, I believe the best way is to standardize serialization to string.