Update type of CoreOptions.jar #4
Conversation
|
Even after every fix I still had issues so I just looked the cookie code. Looks like I will have to add an other commit to finally nail it: |
| @@ -1,8 +1,8 @@ | |||
| import {Stream} from 'stream'; | |||
| import {Agent, ClientRequest, IncomingMessage} from 'http'; | |||
| import {Url} from 'url'; | |||
| // import {Url} from 'url'; | |||
There was a problem hiding this comment.
wouldn't it be better if we remove this line?
There was a problem hiding this comment.
Ok, I'll remove it.
I'll send a new commit in ten minutes.
|
LGTM. Just that one comment. |
…apper for tough-cookie's CookieJar)
|
Ok, I just updated the definitions. |
|
Ok, looks like I made an error: this namespace should only declare types/interfaces (classes are forbidden). @louy Sorry to bother you this much about it, but now it should finally be OK |
|
No worries. Here's an idea though: create a new file One other way to keep is as a class is to put it inside the |
|
Ok, I think that I will use the first idea and reorganize the typings to match the project structure. (by creating a I'll do it tomorrow in a new PR and add comments as discussed in #5. (It's a bigger change) |
|
Sounds good. |
|
Nice, thank you for your comments. |
|
You're welcome! |
This PR fixes #3
It is related to this erroneous commit.